Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): print correct fade direction #10450

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

Fixes print of fade direction in ledcFade example.

Tests scenarios

Locally

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: Example Issue is related to specific example. label Oct 11, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(example): Codespell fix":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against c21ff28

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S30⚠️ +560.00⚠️ +0.02000.000.00
ESP32S20⚠️ +560.00⚠️ +0.02000.000.00
ESP32C30⚠️ +480.00⚠️ +0.02000.000.00
ESP32C60⚠️ +480.00⚠️ +0.02000.000.00
ESP32H20⚠️ +480.00⚠️ +0.02000.000.00
ESP320⚠️ +560.00⚠️ +0.02000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ESP32/examples/AnalogOut/LEDCFade⚠️ +560⚠️ +560⚠️ +480⚠️ +480⚠️ +480⚠️ +560

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Test Results

 56 files   -  99   56 suites   - 99   4m 17s ⏱️ - 1h 42m 52s
 21 tests  -  12   21 ✅  -  10  0 💤 ±0  0 ❌ ±0 
135 runs   - 189  135 ✅  - 183  0 💤 ±0  0 ❌ ±0 

Results for commit c21ff28. ± Comparison against base commit f083e2d.

This pull request removes 12 tests.
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.linpack_double.test_linpack_double ‑ test_linpack_double
performance.linpack_float.test_linpack_float ‑ test_linpack_float
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
…

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added the Status: Pending Merge Pull Request is ready to be merged label Oct 11, 2024
@me-no-dev me-no-dev removed the Status: Pending Merge Pull Request is ready to be merged label Oct 11, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev October 11, 2024 13:59
@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Oct 15, 2024
@me-no-dev
Copy link
Member

@me-no-dev me-no-dev merged commit 955b277 into espressif:master Oct 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: Example Issue is related to specific example.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants