Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Matter Light README.md #10357

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Update Matter Light README.md #10357

merged 4 commits into from
Sep 24, 2024

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Sep 19, 2024

Update Matter Light README.md
Following #10356 but against master branch

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

PR #10356

Update Matter Light README.md
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update Matter Light README.md":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(matter): extended formating ":
    • summary looks too short

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello lboue, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 1907f58

@lboue lboue marked this pull request as ready for review September 19, 2024 16:49
@SuGlider SuGlider self-assigned this Sep 20, 2024
@SuGlider SuGlider added this to the 3.0.5 milestone Sep 20, 2024
used the same formatting for the whole document and changed a few expresssions.
@SuGlider SuGlider self-requested a review September 20, 2024 00:58
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @lboue !! LGTM.

@SuGlider SuGlider requested a review from me-no-dev September 20, 2024 00:58
@SuGlider SuGlider added the Status: Pending Merge Pull Request is ready to be merged label Sep 20, 2024
@SuGlider SuGlider self-requested a review September 20, 2024 01:18
@SuGlider SuGlider removed the Status: Pending Merge Pull Request is ready to be merged label Sep 23, 2024
@SuGlider
Copy link
Collaborator

@me-no-dev - this is ready.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Sep 24, 2024
@me-no-dev me-no-dev merged commit ae052f4 into espressif:master Sep 24, 2024
11 of 12 checks passed
@lboue lboue deleted the patch-5 branch October 13, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

3 participants