-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add waveshare_esp32_touch_amoled_241 #10342
Conversation
👋 Hello wurongmin, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
46c39bd
to
9546d62
Compare
Why is there a red error? Does it indicate that manual review is needed? |
missing proper declaration for UART and SPI pins |
I modified the UART, SPI, and the name suffix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Component name: Waveshare_ESP32_TOUCH_AMOLED_241, for use in md files. I would like the board name to be Waveshare ESP32-Touch-AMOLED-2.41.
This application will provide us with great publicity. The board has not been officially launched yet, but I can add the link once it is live. Our company's official website: https://www.waveshare.net/.