-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebServer] Mark functions as const + reduce copy of strings #10339
[WebServer] Mark functions as const + reduce copy of strings #10339
Conversation
👋 Hello TD-er, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 56 files - 83 56 suites - 83 4m 57s ⏱️ - 1h 37m 48s Results for commit 161434f. ± Comparison against base commit 4e9eb35. This pull request removes 9 tests.
♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Wow, quick merges :) |
Description of Change
A few functions in WebServer does have
String
arguments, which does lead to copying of the strings when calling those functions.For those where applicable, I changed the function arguments to
const String&
.Also some functions which do not modify members, were not marked as
const
. Added those too.