fix(boards): Correct typos in port prop. associations for "Bee" boards #10276
Conversation
👋 Hello per1234, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
I'm very uptight about commits, but some of the requirements you guys are imposing with this DangerJS thing are ridiculous. It makes your repository really hostile to casual contributors. |
VID and PID port property values are hexadecimal literals and thus use the standard "0x" prefix. Previously, this prefix was missing from the PID port property association in the definition of the board definition of "Bee Data Logger" board. This typo caused ports having the 0x303a, 0x815C VID/PID pair to not be identified as a "Bee Data Logger" board as intended.
These properties are intended to associate values of the PID port property with "Bee" board definitions. A typo caused them to instead associatiate the values with the VID port property. The result was that ports with this VID/PID pair were not identified by the Arduino development software as the board model as intended.
per1234
force-pushed
the
port-properties-typos
branch
from
b5618b3
to
87ad6e9
Compare
Description of Change
These properties are intended to associate VID/PID pairs with the "Bee" board definitions:
https://arduino.github.io/arduino-cli/dev/platform-specification/#properties-from-pluggable-discovery:~:text=upload_port.vid%20and%20upload_port.pid%20properties
Typos caused incorrect VID and PID values to be associated. The result was that ports with this VID/PID pair were not identified by the Arduino development software as the board model as intended.
This pull request fixes the typos.
Tests scenarios
Compile for the modified boards using the platform (at 0b8eede) with this patch applied.