Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards): Add ESP32-2432S028R board support #10235

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

Xylopyrographer
Copy link
Contributor

Description of Change

Add support for the JCZN ESP32-2432S028R, aka Cheap Yellow Display (CYD), development board.

  • Includes two custom partition schemes
  • Includes revised naming conventions for Rainmaker 4MB partitions

Tests scenarios

Tested with the JCZN ESP32-2432S028R board with

  • Arduino IDE v2.3.2 using arduino-esp32 core v3.0.4 on Debian-Linux 12.
  • Arduino IDE v2.3.2 using arduino-esp32 core v2.0.17 on macOS 14.6.1

Related links

None

Add support for the ESP32-2432S028R, aka Cheap Yellow Display (CYD) dev board.
Add ESP32-2432S028R, aka Cheap Yellow Display (CYD) variant
Copy link
Contributor

github-actions bot commented Aug 24, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Add ESP32-2432S028R dev board":
    • probably contains Jira ticket reference (ESP32-2432, ESP32-2432). Please remove Jira tickets from commit messages.
    • summary looks empty
    • type/action looks empty
  • the commit message "Add ESP32-2432S028R variant":
    • probably contains Jira ticket reference (ESP32-2432, ESP32-2432). Please remove Jira tickets from commit messages.
    • summary looks empty
    • type/action looks empty
  • the commit message "Revise macro defined function names":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 4 commits (simplifying branch history).

👋 Hello Xylopyrographer, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 039bae3

@Xylopyrographer Xylopyrographer changed the title feat(boards) Add ESP32-2432S028R board support feat(boards): Add ESP32-2432S028R board support Aug 24, 2024
Append brackets to all macro defined function names
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Aug 26, 2024
@me-no-dev me-no-dev merged commit 4178e66 into espressif:master Aug 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants