ArduinoOTA - change occurrence of client.flush() to clear() #10233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as follow up of changing flush() to clear() in networking with PR #9453, there is an unclear use of
flush()
in ArduinoOTA.The UDP object in ArduinoOTA is used to receive and send messages in
handle()
. The function _onRx invoked inhandle()
before flush()) reads a message and then sends a response. So it is unclear what the flush() in handle() was meant to do.But the library would fail if for some reason _onRx doesn't read the whole incoming message because then all following parsePacket will always return 0 (and this is not a good behavior of the NetworkUDP class).