-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contrib): Add instructions on how to test changes #10221
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@Jason2866 @mathieucarbou PTAL. |
Thank you I will go though the doc when I will be back from vacation and try it for my PR #10186 |
Thank you. Exactly what i wanted to know. Will try some ;-) Feedback follows. Will need some days ;-) |
looks really nice @lucasssvaz! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9534bbc
to
ee8db6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
Add instructions on how to create and run tests.
Fix formatting.
Tests scenarios
Built locally
Related links
Closes #10185