Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wifiprov): Fix starting Wifi when already provisioned #10151

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR fixes WiFi STA was not starting when already provisioned after device reset.

Tests scenarios

Tested with RainMaker Switch example

Related links

Related #10119

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: WiFi Issue related to WiFi label Aug 13, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.0.5 milestone Aug 13, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from me-no-dev August 13, 2024 11:35
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 13, 2024
Copy link
Contributor

github-actions bot commented Aug 13, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against b174bc1

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C30⚠️ +40.000.00000.000.00
ESP32C60⚠️ +40.000.00000.000.00
ESP320⚠️ +40.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
WiFiProv/examples/WiFiProv0000⚠️ +40⚠️ +40⚠️ +40

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Test Results

 56 files   56 suites   4m 54s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
135 runs  135 ✅ 0 💤 0 ❌

Results for commit b174bc1.

♻️ This comment has been updated with latest results.

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Aug 13, 2024
@me-no-dev me-no-dev merged commit 4aab817 into espressif:master Aug 13, 2024
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: WiFi Issue related to WiFi Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

2 participants