Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MQTT): Add enable, disable and enable_on_boot #7716

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

Rapsssito
Copy link
Contributor

@Rapsssito Rapsssito commented Nov 3, 2024

What does this implement/fix?

Adds mqtt.enable and mqtt.disable actions and enable_on_boot optional parameter, just like BLE and WiFi. This PR comes after the discord discussion about #7327, allowing users to delay the MQTT component setup so they can use lambdas to adapt the configuration to their own setup.

Provides a workaround for this forum post.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
esphome:
  on_boot:
    - priority: -100
      then:
        - mqtt.enable
        - delay: 20s
        - mqtt.disable
        - delay: 20s
        - mqtt.enable
       
mqtt:
  broker: "192.168.178.84"
  port: 1883
  username: debug
  password: debug
  enable_on_boot: false

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.98%. Comparing base (4d8b5ed) to head (26c6d9c).
Report is 1555 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7716      +/-   ##
==========================================
+ Coverage   53.70%   53.98%   +0.27%     
==========================================
  Files          50       50              
  Lines        9408     9766     +358     
  Branches     1654     1344     -310     
==========================================
+ Hits         5053     5272     +219     
- Misses       4056     4170     +114     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesserockz jesserockz merged commit 80b4c26 into esphome:dev Nov 6, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@Rapsssito Rapsssito deleted the mqtt_enable branch November 14, 2024 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants