Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump platformio to 6.1.16 to support py3.13 build #7590

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

chenrui333
Copy link
Contributor

bump platformio and PyYAML to build with py3.13

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:


relates to Homebrew/homebrew-core#193910

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.04%. Comparing base (4d8b5ed) to head (0cf7909).
Report is 1463 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7590      +/-   ##
==========================================
+ Coverage   53.70%   54.04%   +0.33%     
==========================================
  Files          50       50              
  Lines        9408     9715     +307     
  Branches     1654     1345     -309     
==========================================
+ Hits         5053     5250     +197     
- Misses       4056     4139      +83     
- Partials      299      326      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump PyYAML in its own PR

@esphome
Copy link

esphome bot commented Oct 13, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft October 13, 2024 18:55
@chenrui333
Copy link
Contributor Author

sounds good, will split it out then.

@chenrui333 chenrui333 changed the title chore: bump platformio and PyYAML to build with py3.13 chore: bump platformio to 6.1.16 to support py3.13 build Oct 16, 2024
@chenrui333 chenrui333 requested a review from jesserockz October 16, 2024 03:51
@chenrui333
Copy link
Contributor Author

relates to Homebrew/homebrew-core#194569

@jesserockz jesserockz marked this pull request as ready for review October 16, 2024 04:26
@jesserockz jesserockz merged commit 22478ff into esphome:dev Oct 16, 2024
33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@chenrui333 chenrui333 deleted the fix-py3.13-build branch October 23, 2024 22:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants