Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Seeed Studio mr60fda2 mmwave sensor #7576

Merged
merged 45 commits into from
Nov 26, 2024
Merged

Add: Seeed Studio mr60fda2 mmwave sensor #7576

merged 45 commits into from
Nov 26, 2024

Conversation

limengdu
Copy link
Contributor

@limengdu limengdu commented Oct 10, 2024

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4330

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
uart:
  id: uart_bus
  baud_rate: 115200
  rx_pin: 17
  tx_pin: 16
  parity: NONE
  stop_bits: 1

seeed_mr60fda2:
  id: my_seeed_mr60fda2

text_sensor:
  - platform: seeed_mr60fda2
    is_fall:
      name: "Falling Information"

binary_sensor:
  - platform: seeed_mr60fda2
    people_exist:
      name: "Person Information"

button:
  - platform: seeed_mr60fda2
    get_radar_parameters:
      name: "Get Radar Parameters"
    reset_radar:
      name: "Reset"

select:
  - platform: seeed_mr60fda2
    install_height:
      name: "Set Install Height"
    height_threshold:
      name: "Set Height Threshold"
    sensitivity:
      name: "Set Sensitivity"

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @limengdu,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@limengdu"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.99%. Comparing base (4d8b5ed) to head (887efbb).
Report is 1558 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7576      +/-   ##
==========================================
+ Coverage   53.70%   53.99%   +0.28%     
==========================================
  Files          50       50              
  Lines        9408     9766     +358     
  Branches     1654     1344     -310     
==========================================
+ Hits         5053     5273     +220     
- Misses       4056     4167     +111     
- Partials      299      326      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only add 1 new component per PR

@esphome esphome bot marked this pull request as draft October 10, 2024 03:05
@esphome
Copy link

esphome bot commented Oct 10, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@limengdu limengdu changed the title Add: Seeed Studio mr60fda2 and mr60bha2 mmwave sensor Add: Seeed Studio mr60fda2 mmwave sensor Oct 10, 2024
@limengdu limengdu marked this pull request as ready for review October 11, 2024 03:06
@esphome esphome bot requested a review from jesserockz October 11, 2024 03:06
@jesserockz
Copy link
Member

@Love4yzp
Copy link
Contributor

https://esphome.io/guides/contributing#force-push

I apologize for the trouble caused by the force push. I didn’t realize it would have such an impact. I used force push because the rule failure was caused by a very minor issue, and I wanted to keep the commit history clean.

Should I make any necessary adjustments to restore the branch?

@jesserockz
Copy link
Member

No, please dont try to fix it anymore, it cant get better..haha
We dont care too much for commit history as PRs are squashed into a single commit when merged.

Please just keep it in mind for future PRs =)

esphome/components/seeed_mr60fda2/button/__init__.py Outdated Show resolved Hide resolved
esphome/components/seeed_mr60fda2/select/__init__.py Outdated Show resolved Hide resolved
esphome/components/seeed_mr60fda2/select/__init__.py Outdated Show resolved Hide resolved
esphome/components/seeed_mr60fda2/seeed_mr60fda2.cpp Outdated Show resolved Hide resolved
esphome/components/seeed_mr60fda2/seeed_mr60fda2.cpp Outdated Show resolved Hide resolved
esphome/components/seeed_mr60fda2/seeed_mr60fda2.cpp Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft October 24, 2024 01:19
@limengdu limengdu marked this pull request as ready for review October 25, 2024 07:46
@esphome esphome bot requested a review from jesserockz October 25, 2024 07:46
esphome/components/seeed_mr60fda2/seeed_mr60fda2.cpp Outdated Show resolved Hide resolved
esphome/components/seeed_mr60fda2/seeed_mr60fda2.cpp Outdated Show resolved Hide resolved
esphome/components/seeed_mr60fda2/seeed_mr60fda2.cpp Outdated Show resolved Hide resolved
esphome/components/seeed_mr60fda2/seeed_mr60fda2.h Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft October 30, 2024 03:46
@limengdu limengdu marked this pull request as ready for review November 5, 2024 09:54
@esphome esphome bot requested a review from jesserockz November 5, 2024 09:54
@jesserockz jesserockz merged commit c0dcecc into esphome:dev Nov 26, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants