-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Seeed Studio mr60fda2 mmwave sensor #7576
Conversation
Hey there @limengdu, CODEOWNERS = ["@limengdu"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7576 +/- ##
==========================================
+ Coverage 53.70% 53.99% +0.28%
==========================================
Files 50 50
Lines 9408 9766 +358
Branches 1654 1344 -310
==========================================
+ Hits 5053 5273 +220
- Misses 4056 4167 +111
- Partials 299 326 +27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only add 1 new component per PR
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I apologize for the trouble caused by the force push. I didn’t realize it would have such an impact. I used force push because the rule failure was caused by a very minor issue, and I wanted to keep the commit history clean. Should I make any necessary adjustments to restore the branch? |
No, please dont try to fix it anymore, it cant get better..haha Please just keep it in mind for future PRs =) |
What does this implement/fix?
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#4330
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: