Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-quality] fix clang-tidy cstddef #7324

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

tomaszduda23
Copy link
Contributor

@tomaszduda23 tomaszduda23 commented Aug 20, 2024

What does this implement/fix?

### File /esphome/.temp/all-include.cpp

/esphome/esphome/components/microphone/microphone.h:3:10: error: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers,-warnings-as-errors]
#include <stddef.h>
         ^~~~~~~~~~
         <cstddef>
/esphome/esphome/components/speaker/speaker.h:3:10: error: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers,-warnings-as-errors]
#include <stddef.h>
         ^~~~~~~~~~
         <cstddef>

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (microphone) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (speaker) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.95%. Comparing base (4d8b5ed) to head (f85b8a8).
Report is 1186 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7324      +/-   ##
==========================================
+ Coverage   53.70%   53.95%   +0.24%     
==========================================
  Files          50       50              
  Lines        9408     9665     +257     
  Branches     1654     1706      +52     
==========================================
+ Hits         5053     5215     +162     
- Misses       4056     4126      +70     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, interesting as when I changed these recently it was complaining it could not find size_t without the stddef.h. I tried cstddef but it was not working at the time. Maybe a cache thing.

@jesserockz jesserockz merged commit fa497d0 into esphome:dev Aug 20, 2024
31 checks passed
@nielsnl68
Copy link
Contributor

Huh, interesting as when I changed these recently it was complaining it could not find size_t without the stddef.h. I tried cstddef but it was not working at the time. Maybe a cache thing.

I saw this behavier also popping up while i was doing the changes on the speaker.h file etc.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants