-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homeassistant] Native number entity import and control #6455
Conversation
…rom home assistant
Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @landonr, CODEOWNERS = ["@landonr"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6455 +/- ##
==========================================
+ Coverage 53.70% 53.94% +0.23%
==========================================
Files 50 50
Lines 9408 9655 +247
Branches 1654 1705 +51
==========================================
+ Hits 5053 5208 +155
- Misses 4056 4124 +68
- Partials 299 323 +24 ☔ View full report in Codecov by Sentry. |
I think that the attributes like |
I think I agree, I'll make the changes and see how it works. thanks! |
works great, nice suggestion thanks |
@nagyrobi can you take another look |
I removed all of the timeout stuff and also added a simple We can add more protections back in later if needed, but in my basic number testing, it was fine. |
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
What does this implement/fix?
I'm adding the number component which I tested using a graphical display menu config
Home Assistant Component
can_update_from_api
all of this is used in combination to keep the device's entity in sync with the API as close as possible. This works for most devices like switches, numbers, covers, but it can be a bit buggy for more complicated entities like Lights.
Types of changes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3942
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: