Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component_tests config #1608

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix component_tests config #1608

merged 1 commit into from
Mar 12, 2021

Conversation

madron
Copy link
Contributor

@madron madron commented Mar 12, 2021

What does this implement/fix?

This is a fix for the component_tests.
They were not executed and didn't work.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (this will require users to update their yaml configuration files to keep working)

Test Environment

  • ESP32
  • ESP8266
  • Windows
  • Mac OS
  • Linux

Explain your changes

I'm planning to develop a new component and I'd like to add some tests for it.
Unluckily this in not possible as the component_tests don't work.

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@glmnet
Copy link
Member

glmnet commented Mar 12, 2021

Thanks

SenexCrenshaw pushed a commit to SenexCrenshaw/esphome that referenced this pull request Mar 13, 2021
@madron madron deleted the component_tests branch March 13, 2021 09:03
taquitos pushed a commit to taquitos/esphome that referenced this pull request Mar 14, 2021
This was referenced Mar 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants