Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial LVGL doc for ESPHome #3678

Merged
merged 640 commits into from
Aug 11, 2024
Merged

Initial LVGL doc for ESPHome #3678

merged 640 commits into from
Aug 11, 2024

Conversation

nagyrobi
Copy link
Member

@nagyrobi nagyrobi commented Mar 12, 2024

Description:

Doc for LVGL v8 in ESPHome. Only to be merged when all the code PRs are done.

Related issue (if applicable): N/A

Pull request in esphome with YAML changes (if applicable): esphome/esphome#7116 (base implementation!)

Complete implementation for easy testing at esphome/esphome#6363

Doc preview at: https://deploy-preview-3678--esphome.netlify.app/components/lvgl

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /index.rst when creating new documents for new components or cookbook.

@probot-esphome probot-esphome bot added the next label Mar 12, 2024
@nagyrobi nagyrobi mentioned this pull request Mar 12, 2024
3 tasks
@nagyrobi nagyrobi marked this pull request as draft March 12, 2024 09:43
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 3d5bb6a
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/66b93a39366a0300082275e2
😎 Deploy Preview https://deploy-preview-3678--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an amazing document & effort! 🍻 As you requested, I had a look and left...a few...comments. 😅 This is as far as I was able to get today; I'll continue tomorrow. 😇

components/binary_sensor/lvgl.rst Outdated Show resolved Hide resolved
components/binary_sensor/lvgl.rst Outdated Show resolved Hide resolved
components/binary_sensor/lvgl.rst Outdated Show resolved Hide resolved
components/binary_sensor/lvgl.rst Outdated Show resolved Hide resolved
components/display/fonts.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
@nagyrobi
Copy link
Member Author

nagyrobi commented May 9, 2024

This is an amazing document & effort! 🍻 As you requested, I had a look and left...a few...comments. 😅 This is as far as I was able to get today; I'll continue tomorrow. 😇

Thanks!

Content is still being added, as since Jesse didn't want to merge it in the most recent beta Clyde decided to add a few more useful things.

@kbx81
Copy link
Member

kbx81 commented May 9, 2024

@nagyrobi I think you may have missed some of my comments since GH hides them to "shrink" the page. 😅

Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I need another break 😅

components/sensor/lvgl.rst Outdated Show resolved Hide resolved
components/sensor/lvgl.rst Outdated Show resolved Hide resolved
components/sensor/lvgl.rst Outdated Show resolved Hide resolved
components/sensor/lvgl.rst Outdated Show resolved Hide resolved
components/text/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
components/lvgl.rst Outdated Show resolved Hide resolved
nagyrobi and others added 3 commits May 10, 2024 06:51
@nagyrobi
Copy link
Member Author

@nagyrobi I think you may have missed some of my comments since GH hides them to "shrink" the page. 😅

I keep running into that

nagyrobi and others added 2 commits May 10, 2024 09:04
@jesserockz jesserockz reopened this Aug 6, 2024
@jesserockz
Copy link
Member

Please don't just throw away this PR because of some merge conflicts that took me all of 30 seconds to fix.

@jesserockz jesserockz mentioned this pull request Aug 6, 2024
3 tasks
@nagyrobi nagyrobi marked this pull request as ready for review August 6, 2024 22:13
@esphome esphome bot requested a review from jesserockz August 6, 2024 22:13
@kbx81 kbx81 mentioned this pull request Aug 8, 2024
3 tasks
@jesserockz jesserockz merged commit db2fda7 into esphome:next Aug 11, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants