Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump protobuf to 25.5 (aka PyPi 4.25.5) #992

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Bump protobuf to 25.5 (aka PyPi 4.25.5) #992

merged 2 commits into from
Dec 6, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 6, 2024

Home Assistant currently uses protobuf==5.28.3 and only one major version ahead is technically supported so we seeing issues like home-assistant/core#129052 home-assistant/core#130169

Note that the problem only appears if C extensions are not working and protobuf falls back to the pure python version

Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #992 will not alter performance

Comparing protobuf_4_bump (3242f7c) with main (0221118)

Summary

✅ 2 untouched benchmarks

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0221118) to head (3242f7c).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #992   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         2673      2673           
=========================================
  Hits          2673      2673           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hcjehg
Copy link

hcjehg commented Nov 9, 2024

It seems this has failed on
@github-actions CI / py 3.12 on ubuntu-latest (skip_cython) (pull_request) Failing after 1m

:-)

@hcjehg
Copy link

hcjehg commented Nov 16, 2024

It seems this still fails :-)
CI / py 3.12 on ubuntu-latest (skip_cython) (pull_request) Failing after 1m

@bdraco bdraco marked this pull request as ready for review December 6, 2024 01:03
@bdraco bdraco merged commit 1034a22 into main Dec 6, 2024
16 of 18 checks passed
@bdraco bdraco deleted the protobuf_4_bump branch December 6, 2024 01:04
Copy link
Contributor

coderabbitai bot commented Dec 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several updates across multiple files. The Dockerfile updates the Protocol Buffers compiler version from 3.19.6 to 25.5. The aioesphomeapi/api_options_pb2.py file undergoes significant restructuring to simplify the construction and registration of protocol buffer messages and enums using a new builder pattern. Additionally, the pyproject.toml file is modified to refine configuration settings for code formatting and linting tools, including updated exclusion lists for specific files.

Changes

File Change Summary
Dockerfile Updated PROTOC_VERSION from 3.19.6 to 25.5; architecture variable now used for downloading.
aioesphomeapi/api_options_pb2.py Restructured protocol buffer definitions using _builder; added new enum and fields.
pyproject.toml Updated exclusion lists for linting and formatting; specified required version for ruff.

Possibly related PRs

  • Ruff updates #915: The changes in pyproject.toml regarding the exclusion of aioesphomeapi/api_options_pb2.py are related to the main PR's updates to the Protocol Buffers compiler, as both involve modifications to the handling of Protocol Buffers files.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cd44511 and 3242f7c.

📒 Files selected for processing (3)
  • Dockerfile (1 hunks)
  • aioesphomeapi/api_options_pb2.py (2 hunks)
  • pyproject.toml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants