Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up decrypting frames #944

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Speed up decrypting frames #944

merged 6 commits into from
Sep 3, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 3, 2024

Wrap the rust object in a cython wrapper to avoid multiple levels of useless checks to see if there is a key for every packet since we know there always well be.

@bdraco bdraco marked this pull request as ready for review September 3, 2024 21:42
@bdraco bdraco merged commit 7e7ece4 into main Sep 3, 2024
13 checks passed
@bdraco bdraco deleted the decrypt branch September 3, 2024 21:43
Copy link
Contributor

coderabbitai bot commented Sep 3, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce two new classes, EncryptCipher and DecryptCipher, to encapsulate encryption and decryption processes using the ChaCha20Poly1305 cipher. The APINoiseFrameHelper class is updated to utilize these new classes, replacing previous callable attributes for encryption and decryption. This restructuring enhances the organization of the code related to encryption and decryption operations.

Changes

Files Change Summary
aioesphomeapi/_frame_helper/noise.pxd Added EncryptCipher and DecryptCipher classes; modified APINoiseFrameHelper to use these classes for encryption and decryption.
aioesphomeapi/_frame_helper/noise.py Introduced EncryptCipher and DecryptCipher classes with methods for encryption and decryption; updated APINoiseFrameHelper to instantiate and use these classes.

Tip

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant