Copy audio buffer and send for playback without blocking, fixes Windows audio choppyness #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws audio choppyness
alex19EP
approved these changes
Aug 16, 2022
|
I think you can add closes keyword to espeak-ng/espeak-ng#1190 in pr description otherwise looks good. thank you for contribution! |
|
@alex19EP check now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes espeak-ng/espeak-ng#1190
Fixes audio choppyness in Windows.
Added callback for OnBufferEnd to free the manually malloced audio buffer memory.
Blocks on write only if SubmitSourceBuffer() fails, as that means the XAudio2 SourceVoice interface is full and can't accept anymore buffers - so we'll just block until it succeeds.
Otherwise write is now non-blocking, so no gaps in audio playback anymore. Also, drain now waits for the all of the remaining buffers to be played back.