Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github action: enforce issue detection with bash #8168

Merged
merged 5 commits into from
Jun 24, 2021
Merged

github action: enforce issue detection with bash #8168

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c294c8
github action: enforce bash default configuration
d-a-v Jun 23, 2021
a083c11
(not for windows)
d-a-v Jun 23, 2021
f060ac6
fix quoting and split another command
d-a-v Jun 23, 2021
bbb9b84
Merge branch 'master' into enforceCI
d-a-v Jun 24, 2021
d63086d
Merge branch 'master' into enforceCI
earlephilhower Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
build-linux:
name: Build ${{ matrix.chunk }}
runs-on: ubuntu-latest
defaults:
run:
shell: bash
strategy:
matrix:
chunk: [0, 1, 2, 3, 4, 5, 6, 7]
Expand Down Expand Up @@ -47,6 +50,9 @@ jobs:
build-debug-ipv6:
name: Debug IPv6 ${{ matrix.chunk }}
runs-on: ubuntu-latest
defaults:
run:
shell: bash
strategy:
matrix:
chunk: [0, 1, 2, 3, 4, 5, 6, 7]
Expand Down Expand Up @@ -110,6 +116,9 @@ jobs:
build-mac:
name: Mac
runs-on: macOS-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand Down Expand Up @@ -139,6 +148,9 @@ jobs:
build-pio:
name: Build Platform.IO
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -163,6 +175,9 @@ jobs:
host-tests:
name: Host tests
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -184,6 +199,9 @@ jobs:
documentation:
name: Documentation
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -208,6 +226,9 @@ jobs:
style-check:
name: Style and formatting
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -229,6 +250,9 @@ jobs:
mock-check:
name: Mock trivial test
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -248,6 +272,9 @@ jobs:
boards-check:
name: Boards.txt check
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand Down Expand Up @@ -275,6 +302,9 @@ jobs:
code-spell:
name: Check spelling
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/release-to-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ jobs:
package:
name: Update master JSON file
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/tag-to-draft-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ jobs:
package:
name: Package
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -25,7 +28,8 @@ jobs:
- name: Set GIT tag name
run: |
# Sets an environment variable used in the next steps
echo "TRAVIS_TAG=$(git describe --exact-match --tags)" >> $GITHUB_ENV
TRAVIS_TAG=$(git describe --exact-match --tags)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TRAVIS_TAG=$(git describe --exact-match --tags)"
TRAVIS_TAG=$(git describe --exact-match --tags)

(I typed this wrong)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing (I didn't make a copy-paste, It's simply that I made the same mistake)

echo "TRAVIS_TAG=${TRAVIS_TAG}" >> $GITHUB_ENV
- name: Build package JSON
env:
TRAVIS_BUILD_DIR: ${{ github.workspace }}
Expand Down