-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full consolidation of "phase locking" and "PWM locking" waveform generators #8011
Open
dok-net
wants to merge
16
commits into
esp8266:master
Choose a base branch
from
dok-net:mergepwm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dok-net
force-pushed
the
mergepwm
branch
5 times, most recently
from
May 1, 2021 20:38
255baa3
to
1579b85
Compare
dok-net
force-pushed
the
mergepwm
branch
7 times, most recently
from
May 3, 2021 17:30
42089c6
to
24f77b9
Compare
dok-net
changed the title
[WIP] Full consolidation of "phase locking" and "PMW locking" waveform generators
Full consolidation of "phase locking" and "PMW locking" waveform generators
May 3, 2021
dok-net
force-pushed
the
mergepwm
branch
7 times, most recently
from
May 19, 2021 08:34
c6b902b
to
92d1d4a
Compare
dok-net
force-pushed
the
mergepwm
branch
6 times, most recently
from
June 6, 2021 10:07
166f61f
to
69448a9
Compare
dok-net
force-pushed
the
mergepwm
branch
2 times, most recently
from
September 2, 2021 05:46
d3d32a6
to
a93d42e
Compare
dok-net
force-pushed
the
mergepwm
branch
3 times, most recently
from
October 19, 2021 05:32
a2074bb
to
ddc6403
Compare
dok-net
force-pushed
the
mergepwm
branch
2 times, most recently
from
December 3, 2021 00:16
e4f6fa9
to
abcf2cf
Compare
dok-net
force-pushed
the
mergepwm
branch
3 times, most recently
from
March 13, 2022 20:22
4ce0522
to
38eee50
Compare
startWaveform already implied stopping PWM before.
…plemented on next PWM period begin anyway.
…ick up new starts at next regular interval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now needs review and testing.
At time of publishing, the following MCVE works for eyes and ears, not tested with an oscilloscope by myself yet:
Fixes #8081.