Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow serial baudrates: add yields #7753

Closed
wants to merge 11 commits into from

Conversation

HakamSaffour
Copy link

As discussed in : #7746

Signed-off-by: Hakam Saffour [email protected]

Copy link
Collaborator

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HakamSaffour this PR looks like a bunch of stuff got thrown into the 1-line change you were trying to submit. Please look at it and clear out the unneeded changes.

@d-a-v d-a-v added the waiting for feedback Waiting on additional info. If it's not received, the issue may be closed. label Dec 11, 2020
@d-a-v
Copy link
Collaborator

d-a-v commented Dec 11, 2020

@HakamSaffour It seems you didn't start your pull request on top of the master branch.
You have the option to fix it, or you can start over from a fresh git version of the master branch.

@d-a-v d-a-v changed the title Patch 1 Slow serial baudrates: add yields Dec 11, 2020
@HakamSaffour
Copy link
Author

HakamSaffour commented Dec 11, 2020

Hello @earlephilhower and @d-a-v
I do not have access to create a new branch, therefore I went to branch 2.7.4 and added my changes to uart.cpp

One more thing: I do not have access to change uart.cpp on the master branch.

Can you explain to me, how to create a new branch? or can you do it yourself?

I am closing this PR

@d-a-v
Copy link
Collaborator

d-a-v commented Dec 11, 2020

You need to

git checkout master
git pull upstream master      # upstream is esp8266/arduino
git checkout -b mypatchname   # create your local branch
# apply your patch
git add -p                    # add your change to the branch
git commit
git push origin mypatchname     # push your changes to your repository/clone on github

Then on gihub you have the ability to create the PR.

@HakamSaffour
Copy link
Author

Hello @d-a-v

I do not have permission to push to the repo, see below

git push origin mypatchname     # push your changes to your repository/clone on github
$ git push origin slowbaudrate
fatal: HttpRequestException encountered.
   An error occurred while sending the request.
fatal: HttpRequestException encountered.
   An error occurred while sending the request.
Username for 'https://github.com': [email protected]
remote: Permission to esp8266/Arduino.git denied to HakamSaffour.
fatal: unable to access 'https://github.com/esp8266/Arduino.git/': The requested URL returned error: 403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Waiting on additional info. If it's not received, the issue may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants