-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow serial baudrates: add yields #7753
Conversation
fix for Slow serial baudrates cause exceptions / WDT credit goes to @d-a-v Reference issue: esp8266#7746 Signed-off-by: Hakam Saffour <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HakamSaffour this PR looks like a bunch of stuff got thrown into the 1-line change you were trying to submit. Please look at it and clear out the unneeded changes.
@HakamSaffour It seems you didn't start your pull request on top of the master branch. |
Hello @earlephilhower and @d-a-v One more thing: I do not have access to change uart.cpp on the master branch. Can you explain to me, how to create a new branch? or can you do it yourself? I am closing this PR |
You need to
Then on gihub you have the ability to create the PR. |
Hello @d-a-v I do not have permission to push to the repo, see below
|
As discussed in : #7746
Signed-off-by: Hakam Saffour [email protected]