Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEA mDNS v2 #7540

Merged
merged 178 commits into from
Sep 25, 2020
Merged

LEA mDNS v2 #7540

merged 178 commits into from
Sep 25, 2020

Conversation

Labor-Et-Ars
Copy link
Contributor

@Labor-Et-Ars Labor-Et-Ars commented Aug 20, 2020

  • based on real @LaborEtArs's work on LEAmDNSv2
  • Interface agnostic: a single instance for all interfaces
  • compatible with IPv6
  • experimental, WIP
  • not enabled by default (enabled mDNS remains the same)
  • adapted/updated by @hreintke and @d-a-v

Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, after discussion, I'm approving this as-is due to the size of the PR and complexity of the code, with the understanding that the remaining comments must be addressed in follow up PRs. Some of my comments are of minor impact and open for discussion (e.g.: use of smart ptrs is meant to reduce code fragility), some of my comments are of high impact and eventual must-haves (e.g.: about the define that disables the extern statement for the global MDNS instance).
A general issue should be opened to track the follow up work as a whole, but we can discuss individual comments here for now.
Let's get this one merged!

@d-a-v d-a-v merged commit a3281fe into esp8266:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants