Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ipv4_addr_t for espconn/LwIP1.4 compat #6740

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Add ipv4_addr_t for espconn/LwIP1.4 compat #6740

merged 1 commit into from
Nov 9, 2019

Conversation

pfeerick
Copy link
Contributor

@pfeerick pfeerick commented Nov 9, 2019

espconnn.h references ipv4_addr_t, so it seems appropriate it be defined here also.

If #include <IPAddress.h> added to MCVE, closes #5753.

The change to espconn.h suggested by the OP

#ifndef ipv4_addr_t
#define ipv4_addr_t ip_addr_t
#endif

sets off needing to define ip_addr_t, etc, so is not suitable.

@pfeerick
Add ipv4_addr_t for espconn/LwIP1.4 compat
ba0434b 
`espconnn.h` references ipv4_addr_t, so it seems appropriate it be defined here also.
@d-a-v d-a-v merged commit 2c2468f into esp8266:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-a-v d-a-v d-a-v approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

espconn.h compile error ipv4_addr_t undefined
2 participants
@pfeerick @d-a-v