-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove scheduled functions complexity overhead, change recurrent api #6214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM logically. Minor format/content questions, but nothing stopping a merge for me.
LGTM. |
About malloc() vs. new - is this about exceptions when there is no space on heap, or are there other reasons? After all, just reinterpreting uninitialized memory as std::function<void(void)> (the type of member scheduled_fn_t::mFunc) is undefined in the sense of the C++ type system. According to http://www.cplusplus.com/reference/new/operator%20new/, new (std::nothrow) MyType is specified for that purpose. Besides, this is the code that's actually right in master now at the time of me writing this:
Could it not rather be?
|
@dok-net thanks, the nothrow fix is already done |
edit: