Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to nonos-sdk 2.2.1, new selection menu for generic board only #5763

Merged
merged 10 commits into from
Feb 19, 2019

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Feb 15, 2019

This commit allows switching SDK firmware:

nonos-sdk-pre-v3 shipped with release 2.5.0 has issues:

This PR restores sdk2.2.1 (as in core-2.4.2).

SDK-pre-3.0 - which has brought long awaited fixes (WiFi sleep modes) - is still available through a menu option available only with generic board.

BREAKING

  • new define -DNONOSDK221=1 or -DNONOSDK3V0=1
  • for external build systems: new library directory: tools/sdk/lib/<version>/lib
  • PIO: variable PIO_FRAMEWORK_ARDUINO_ESPRESSIF_SDK3 is needed for sdk-pre-v3.

Fix #5736

This commit allows switching SDK firmware:

Some boards show erratic behavior (radio connection is quickly lost), with
an unknown cause, when using nonos-sdk-pre-v3 (shipped with release 2.5.0).

These boards work well with previous nonos-sdk-2.2.1 firmware.

Current firmware, which has brought long awaited fixes (WiFi sleep modes),
stays as default.

To switch:
           ./tools/boards.txt.py --sdk=NONOSDK221 --allgen
(default)  ./tools/boards.txt.py --sdk=NONOSDK3V0 --allgen

BREAKING for external build systems:
    new directories to add
        lib:     tools/sdk/lib/<version>/lib
        include: tools/sdk/lib/<version>/include

Fix esp8266#5736
@d-a-v d-a-v changed the title Allow reverting SDK by using boards.txt.py Revert to nonos-sdk 2.2.1, new selection menu for generic board only Feb 18, 2019
Copy link
Collaborator

@devyte devyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR hurts my heart, but I agree it's the best path forward for now. Better to assure stability and have a known bug for a specific use case, over random instability and having the bug fix.
I suggest having a master issue to cover the issues in sdk pre3, and link the issues with specific problems to that one. Also, that issue should document the impact of, and how to move between, each of the sdk versions.

@d-a-v d-a-v merged commit 7745e99 into esp8266:master Feb 19, 2019
@d-a-v d-a-v deleted the fwstory branch February 19, 2019 12:10
@Zeron
Copy link

Zeron commented Feb 19, 2019

Any chance of a 2.5.1 version with this fix included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP8266WebServer hangs after updating to 2.5.0
3 participants