fix parseArgument #2 #5252
fix parseArgument #2 #5252
Conversation
key_end_pos--;
dont count down here, it will cut of every key by -1 ("save" will be "sav") (substring (end = up to, but not including, so no need to -1)
Parsing cpp L329
arg.value = urlDecode(data.substring(equal_index + 1, next_index - 1));
=> -1 is too less for substring (substring (end = up to, but not including, so no need to -1)
fix pos substrings
|
Thanks a lot to everyone helping with this great software. 👍 |
|
Tested this commit, working very well with Tasmota, Happy that already merged to master :-) Great Thanks @d-a-v and all the other developers doing a great Job! |
|
Thanks a lot guys, much appreciated! Compiled staged binaries for Tasmota this morning so now its on to more bug hunting ;) |
|
This commit breaks form processing in my project and I had to freeze at commit 2eb5b56 in order to continue functioning. Specifically, in my WebServer.ino, when submitting a POST request none of the expected keys are found in server.hasArg(). Reverting to above mentioned commit restores previous functionality. |
|
OK, made a local pull of 5262 and that fixes my problem, hope it gets merged soon. |
#5230's twin brother using functors on @devyte's proposal
less available flash (-164B), more available ram (+28B)