Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TCP race condition, remove fixed delay in CC #5167

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Fix TCP race condition, remove fixed delay in CC #5167

merged 2 commits into from
Sep 26, 2018

Commits on Sep 25, 2018

  1. Fix TCP race condition, remove fixed delay in CC 

    ClientContext::_wait_for_sent9) could dereference a TCP's _pcb after
the connection was dropped by the OS, resulting in a crash.

Move the connection dropped check to catch this case, and replace
a fixed millisecond delay() with a yield and timeout value to minimize
wasted time when transmission completes.
    @earlephilhower
    earlephilhower committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    7501986 View commit details
    Browse the repository at this point in the history

  2. Fix the return values and address review comments

    @earlephilhower
    earlephilhower committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    9ee6b01 View commit details
    Browse the repository at this point in the history