Fix iostream related issues #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
igrr
commented
Aug 14, 2018
igrr
commented
- add stubs for more exception throw calls (Missing __throw_bad_cast stub #3358)
- make putc_r implementation weak (multiple definition of `_putc_r' #4630)
- fix incorrect return value of _write_r call
- add device test for output to std::cout
6 tasks
d-a-v
approved these changes
Aug 16, 2018
d-a-v
approved these changes
Aug 16, 2018
| std::stringstream test_stream(""); | ||
| test_stream << "hello stream"; | ||
|
|
||
| Serial.readString(); |
There was a problem hiding this comment.
Was meant to clean up UART RX buffer just in case there was something in there. Chances are, the test will also work without this.
And I have messed up the indentation in this line...
devyte
reviewed
Aug 19, 2018
| if (file == STDOUT_FILENO) { | ||
| while(len--) { | ||
| while(pos--) { |
There was a problem hiding this comment.
Does this address a current issue or ongoing discussion? Maybe a link could be added in the PR description if that's the case.
There was a problem hiding this comment.
Haven't seen this reported, probably because including iostream header caused compilation error, so no one got as far as using iostreams. Found when writing the test case.
devyte
approved these changes
Aug 19, 2018
newlib provides its own implementation of _putc_r, which will call _write_r (possibly after buffering). Make our implementation weak to allow using the one from newlib. Fixes #4630
Should return number of bytes written, actually returned zero. This resulted in std::cout going into failed state after the first write.
igrr
force-pushed
the
bugfix/iostream_issues
branch
from
1d8fe68
to
6e906b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.