Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts for comparing core closed libs against esp-nonos-sdk ones #4855

Merged
merged 2 commits into from
Jul 3, 2018

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jun 27, 2018

No description provided.

@d-a-v
Copy link
Collaborator Author

d-a-v commented Jun 27, 2018

Currently, the output of this script gives:

$ ./sdk-compare-libs ~/dev/esp8266/ESP8266_NONOS_SDK

nonos-sdk                 = '.../esp8266/ESP8266_NONOS_SDK'
core root directory       = '.../esp8266/esp8266'
temporary nonos-sdk clone = '.../esp8266/esp8266/tools/sdk/lib/compare/NONOSDK.deleteme'

If libmain.a is not found, it should be the one around the same libpp.a's commit

v2.0.0 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/06b117d691cb2cd1a20d6d0f000b76cf65b2ad67 - libairkiss.a
v2.1.0-67-gb26fe7a - https://github.com/espressif/ESP8266_NONOS_SDK/commit/b26fe7a34cc413a47acb7697358aacf0f2084e2b - libat.a
v2.1.0-7-gb8fd588 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/b8fd588a33f0319dc135523b51655e97b483b205 - libcrypto.a
v2.1.0-1-gcba173c - https://github.com/espressif/ESP8266_NONOS_SDK/commit/cba173c259ee89f23b2c1b4fe3cc3339cd1e8ddc - libdriver.a
v2.1.0-20-gc5d46e9 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/c5d46e9e52ce97866c2e86070748defd3cc5a070 - libespnow.a
v2.0.0 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/06b117d691cb2cd1a20d6d0f000b76cf65b2ad67 - libgcc.a
v2.1.0-7-gb8fd588 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/b8fd588a33f0319dc135523b51655e97b483b205 - libjson.a
v2.1.0-63-g2b59dd2 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/2b59dd22b1d600436956c67d8576c8a884094bcd - liblwip.a
v2.1.0 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/90c641efe84066b47c4616ed367697a9f49f3ac5 - liblwip_536.a
NOTFOUND - libmain.a
v2.1.0-64-gc33ec7b - https://github.com/espressif/ESP8266_NONOS_SDK/commit/c33ec7b57cb32fa57b8426eb30eed68646d769b4 - libnet80211.a
v2.1.0-5-g1826013 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/18260135dfd17f40a6e0afc614bc7ce8d997c270 - libphy.a
v2.2.0-1-gbe748db - https://github.com/espressif/ESP8266_NONOS_SDK/commit/be748db939db8692d6b11f042352bf59a367b221 - libpp.a
v2.0.0 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/06b117d691cb2cd1a20d6d0f000b76cf65b2ad67 - libpwm.a
v2.1.0-60-g67a8b1f - https://github.com/espressif/ESP8266_NONOS_SDK/commit/67a8b1f9cadea29b14e6cd32816d5b101f99fc2d - libsmartconfig.a
v2.1.0-12-g9902466 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/990246645199b31807482ed23f7009e8dc53394b - libssl.a
v2.1.0-7-gb8fd588 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/b8fd588a33f0319dc135523b51655e97b483b205 - libupgrade.a
v2.1.0-20-gc5d46e9 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/c5d46e9e52ce97866c2e86070748defd3cc5a070 - libwpa.a
v2.1.0-20-gc5d46e9 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/c5d46e9e52ce97866c2e86070748defd3cc5a070 - libwpa2.a
v2.1.0-20-gc5d46e9 - https://github.com/espressif/ESP8266_NONOS_SDK/commit/c5d46e9e52ce97866c2e86070748defd3cc5a070 - libwps.a
all done

@devyte
Copy link
Collaborator

devyte commented Jul 3, 2018

I think this could be really useful, but it feels somehow not quite complete. The current output of e.g.: the include compare script shows every difference, and I think that includes our own patches. Therefore, looking at the output is rather confusing.
Maybe our own patches should be factored out somehow, so that the output is cleaner and shows only the differences introduced in the new SDK?
To be clear, I'm ok with merging as is, it can at least serve as a first step.

@d-a-v d-a-v merged commit 7dd2ca3 into esp8266:master Jul 3, 2018
@d-a-v d-a-v deleted the sdkcompare branch July 3, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants