Inefficient Print:write(data,len) shows message if used (only in debug mode) #4537
Conversation
cores/esp8266/Print.cpp
Outdated
| size_t n = 0; | ||
| while (size--) { | ||
| size_t ret = write(*buffer++); | ||
| if (ret == 0) { | ||
| if (ret <= 0) { |
There was a problem hiding this comment.
ret is declared of type size_t, which should be unsigned, which means it can't be negative.
There was a problem hiding this comment.
Yes very true. Blinded with ::read, arduino's api should all get a major reshape for coherency.
cores/esp8266/uart.c
Outdated
| @@ -196,23 +196,30 @@ void uart_stop_isr(uart_t* uart) | |||
| } | |||
|
|
|||
|
|
|||
| void uart_write_char(uart_t* uart, char c) | |||
| void uart_do_write_char(uart_t* uart, char c) | |||
There was a problem hiding this comment.
Maybe declare this one as inline.
There was a problem hiding this comment.
Thanks. I actually don't understand why inline does save flash space here.
This means one while loop and 2 calls with 2 parameters each take 16 more flash bytes than two while loops.
I was thinking gcc -Os would optimize this itself [...] Well, it would have if I had not forgotten static. Then I'd prefer the static way.
devyte
changed the title
…g mode) +fix HardwareSerial that used it
…lls to .h to give gcc a chance to optimize them
|
Last "remove duplicate code" commit spares ~100 bytes of flash. edit: So finally
edit 2: |
…ug mode) (esp8266#4537) * inefficient Print::write(data,len) shows message if used (only in debug mode) * make HardwareSerial's write(data,len) efficient * HardwareSerial: remove duplicate tests, move trivial code from .cpp to .h (cherry picked from commit f8f205d)
+fix HardwareSerial that used it