WiFiClient: clean up ClientContext before connecting #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP because i want to add a test case for this. |
Closed
|
I think the references to "client" should be "_client" |
igrr
force-pushed
the
bugfix/wificlient_connect_leak
branch
from
3e737f4
to
9a4b072
Compare
|
@igrr will you be adding to this pr? |
d-a-v
added a commit
to d-a-v/Arduino
that referenced
this pull request
Mar 22, 2018
|
I think we can merge here |
|
@d-a-v, pretty much, yes :) I got stuck yak shaving trying to remove the need for |
devyte
pushed a commit
that referenced
this pull request
Mar 23, 2018
* device test for #4516 (WiFiClient leaking) * simply count the number of connections that do not change heap * remove unused heapLost * + python server (to not depend on gateway's opened tcp port) * remove old&bad define * fix another old address
|
@igrr is this pr ready for merging, or is additional work needed? |
igrr
changed the title
bryceschober
pushed a commit
to bryceschober/Arduino
that referenced
this pull request
Apr 5, 2018
* device test for esp8266#4516 (WiFiClient leaking) * simply count the number of connections that do not change heap * remove unused heapLost * + python server (to not depend on gateway's opened tcp port) * remove old&bad define * fix another old address (cherry picked from commit d5cbd91)
bryceschober
pushed a commit
to bryceschober/Arduino
that referenced
this pull request
Apr 5, 2018
Fixes esp8266#4497 (cherry picked from commit 95b1348)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4497