Testing - Sigmadelta #4494
Merged
Testing - Sigmadelta #4494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide a simple interface to attach/detach pins to the sigma-delta generator, and get/set the 2 parameters prescaler & target
travis complains about BUILTIN_LED being deprecated
earlephilhower
force-pushed
the
sigmadelta
branch
from
2016895
to
3588f5c
Compare
earlephilhower
force-pushed
the
sigmadelta
branch
from
3588f5c
to
deb9918
Compare
|
#4119 resubmission. I ended up just running astyle manually on the example .ino (which runs great). When this passes I'll squash and merge with a link to his original one. We need an easier way to clean up the style checks, at least show folks how to run the formatter themselves because even the IDE won't fix some of the things it finds (i.e. spaces on a blank line, spaces at the end of a line). |
|
One option would be a CI bot which fixes formatting for you and pushes a commit to your branch. Another is a some instructions how to download astyle and run the script locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to commit @stefaandesmet2003's changes from Unix due to linefeed issues when submitting examples from Windows.