Raise an exception when assert fails #4482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move GDB stub hooks into a separate file, provide header for it - Use syscall instruction raise user mode exception - Remove unused code in postmortem.c fixup fixup
earlephilhower
approved these changes
Mar 9, 2018
|
Let's also look at #4187 for 2.5.0 as well, since it adds the failing assert() condition output to the printed crash dump we'll now be generating with this change. It'll have some merge issues w/this change that I'll clean up once this is in. |
|
Sorry for introducing merge issues, i completely forgot about #4187. If you wish we can merge that one first and i will rebase on top of it. |
|
This is a bugfix, it takes precendence! The merge fixes will take under 5 minutes to fix. |
6 tasks
This was referenced Jul 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4480