Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientContext:_write_some: release buffer once data really accepted for sending #4265

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

d-a-v
Copy link
Collaborator

@d-a-v d-a-v commented Jan 31, 2018

may fix #1872

@d-a-v
Copy link
Collaborator Author

d-a-v commented Feb 1, 2018

I could trigger the bug This happens only with MSS!=1460 (with either lwip v1 or v2 - may be related with the 1460-sized buffers used in core, a PR for MSS instead will come later)

The tcp_write error is -1 (ERR_MEM) and is documented as follow:

The tcp_write() function will fail and return ERR_MEM if the length of the data exceeds the current send buffer size or if the length of the queue of outgoing segment is larger than the upper limit defined in lwipopts.h (TCP_SND_QUEUELEN). If the function returns ERR_MEM, the application should wait until some of the currently enqueued data has been successfully received by the other host and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http.POST() limit of payload size?
2 participants