Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility check for ::config() method with arduino arg order (#1168) #3860

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Add compatibility check for ::config() method with arduino arg order (#1168) #3860

merged 1 commit into from
Nov 22, 2017

Conversation

devyte
Copy link
Collaborator

@devyte devyte commented Nov 22, 2017

Issue #1168 .

@devyte
Copy link
Collaborator Author

devyte commented Nov 22, 2017

@igrr is this what you had in mind?

igrr
igrr approved these changes Nov 22, 2017
View reviewed changes
Copy link
Member

@igrr igrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Looks good!

@devyte devyte merged commit 9dcc580 into esp8266:master Nov 22, 2017
@devyte devyte deleted the issue1168 branch November 26, 2017 05:01
@tve tve mentioned this pull request Jan 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrr igrr igrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devyte @igrr