Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique Built-In libraries library.properties name #1096

Merged
merged 1 commit into from
Jan 10, 2016
Merged

Unique Built-In libraries library.properties name #1096

merged 1 commit into from
Jan 10, 2016

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Nov 27, 2015

Use unique name values in library.properties for the esp8266 libraries
that are also Arduino IDE Built-In libraries. This solves the issue of
SD and Servo libraries always appearing as Type: Updatable in the
Arduino IDE 1.6.6 Library Manager when an esp8266 board is selected.

@marvinroger
Copy link
Contributor

Ethernet and OneWire are conflicting too.

Use unique name values in library.properties for the esp8266 libraries
that are also Arduino IDE Built-In libraries. This solves the issue of
SD and Servo libraries always appearing as Type: Updatable in the
Arduino IDE 1.6.6 Library Manager when an esp8266 board is selected.
@per1234
Copy link
Contributor Author

per1234 commented Dec 1, 2015

I have changed the name values in library.properties for Ethernet and OneWire. I had to create the library.properties for OneWire as there was none so if anyone should be added as author or maintainer or any other changes made I'm happy to do so.

@Testato
Copy link
Contributor

Testato commented Dec 29, 2015

+1
arduino-libraries/Ethernet#1

@marvinroger
Copy link
Contributor

@igrr is there anything preventing this PR to be merged? Licensing issues maybe?

@igrr
Copy link
Member

igrr commented Jan 8, 2016

Sorry this has slipped under the radar. I'll take a look.

@Testato
Copy link
Contributor

Testato commented Jan 8, 2016

A correct way is chance all integrated esp library name, not only ethernet or onewire

@per1234
Copy link
Contributor Author

per1234 commented Jan 8, 2016

A correct way is chance all integrated esp library name, not only ethernet or onewire

@Testato are you suggesting that (esp8266) should be appended to the library.properties name field value of all the libraries included with esp8266? Maybe that would be the right thing for consistency but it's not required to fix the issues because the other libraries either have unique name values already or are only present as libraries bundled with other cores(EEPROM, SPI, Wire).

@igrr if you want more information I have given a more thorough explanation of the purpose of this change here: arduino/ArduinoCore-arc32#94 (comment). I'm happy to make any changes and squash to a single commit.

@Testato
Copy link
Contributor

Testato commented Jan 8, 2016

@per1234 yes, I suggest this in general to all developer. The problem is not only on integrate library but also on all the library.

This is one of my PR that can be a good examples. A developer modified a library but do not insert it in the library manager. But the original developer put his library on Library Manager and here are started the problems. The Board Manager ask to update (so overwrite) the lib of the second developer by the lib of the first devloper

Imroy/pubsubclient#44

@marvinroger
Copy link
Contributor

As @per1234 said, these four libraries are the only ones conflicting. About this PR, what's the benefit of changing all integrated libraries name? IMO none.

igrr added a commit that referenced this pull request Jan 10, 2016
Unique Built-In libraries library.properties name
@igrr igrr merged commit 4710220 into esp8266:master Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants