-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unique Built-In libraries library.properties name #1096
Conversation
|
Use unique name values in library.properties for the esp8266 libraries that are also Arduino IDE Built-In libraries. This solves the issue of SD and Servo libraries always appearing as Type: Updatable in the Arduino IDE 1.6.6 Library Manager when an esp8266 board is selected.
I have changed the name values in library.properties for Ethernet and OneWire. I had to create the library.properties for OneWire as there was none so if anyone should be added as author or maintainer or any other changes made I'm happy to do so. |
@igrr is there anything preventing this PR to be merged? Licensing issues maybe? |
Sorry this has slipped under the radar. I'll take a look. |
A correct way is chance all integrated esp library name, not only ethernet or onewire |
@Testato are you suggesting that @igrr if you want more information I have given a more thorough explanation of the purpose of this change here: arduino/ArduinoCore-arc32#94 (comment). I'm happy to make any changes and squash to a single commit. |
@per1234 yes, I suggest this in general to all developer. The problem is not only on integrate library but also on all the library. This is one of my PR that can be a good examples. A developer modified a library but do not insert it in the library manager. But the original developer put his library on Library Manager and here are started the problems. The Board Manager ask to update (so overwrite) the lib of the second developer by the lib of the first devloper |
As @per1234 said, these four libraries are the only ones conflicting. About this PR, what's the benefit of changing all integrated libraries name? IMO none. |
Unique Built-In libraries library.properties name
Use unique name values in library.properties for the esp8266 libraries
that are also Arduino IDE Built-In libraries. This solves the issue of
SD and Servo libraries always appearing as Type: Updatable in the
Arduino IDE 1.6.6 Library Manager when an esp8266 board is selected.