Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package script should take pre-gen'd JSON from draft, not make a new one #8180

Closed
earlephilhower opened this issue Jun 26, 2021 · 0 comments · Fixed by #8182
Closed

Package script should take pre-gen'd JSON from draft, not make a new one #8180

earlephilhower opened this issue Jun 26, 2021 · 0 comments · Fixed by #8182
Assignees
@earlephilhower

Comments

@earlephilhower
Copy link
Collaborator

The GHCI publish script should not regenerate the ZIP and JSON file before uploading it to the server because the sha256sum of the newly generated ZIP file will not match the one in the release (because of timestamp changes for the source files).

Instead, the package script should just pull the generated JSON file from the release and push it to the boards URL w/o adjustment.
@earlephilhower earlephilhower self-assigned this Jun 26, 2021
earlephilhower added a commit to earlephilhower/Arduino that referenced this issue Jun 26, 2021
@earlephilhower
Copy released JSON to board URL, not new one
b20081a 
Fixes esp8266#8180

The draft release generates a ZIP and JSON.  Instead of rebuilding the ZIP
on the publish step (which may result in a different SHA256 due to file time
differences in the new ZIP), just copy the one from the published release
directly.

Also clean up and remove unneeded environment variables and CI steps.
@earlephilhower earlephilhower mentioned this issue Jun 26, 2021
Merged
d-a-v pushed a commit that referenced this issue Jun 28, 2021
@earlephilhower
Copy released JSON to board URL, not new one (#8182)
d8b70d4 
* Copy released JSON to board URL, not new one

Fixes #8180

The draft release generates a ZIP and JSON.  Instead of rebuilding the ZIP
on the publish step (which may result in a different SHA256 due to file time
differences in the new ZIP), just copy the one from the published release
directly.

Also clean up and remove unneeded environment variables and CI steps.

* Be more paranoid about JSON format, check after d/l
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@earlephilhower earlephilhower

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy released JSON to board URL, not new one earlephilhower/Arduino
1 participant
@earlephilhower