Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSLContext builtin to the WifiClientSecure.cpp file makes it harder to extend WifiClientSecure class #3648

Closed
schlaegerz opened this issue Sep 26, 2017 · 0 comments
Closed

SSLContext builtin to the WifiClientSecure.cpp file makes it harder to extend WifiClientSecure class #3648

schlaegerz opened this issue Sep 26, 2017 · 0 comments
Assignees
@earlephilhower
Labels
component: libraries component: TLS type: enhancement
Milestone
2.5.0

Comments

@schlaegerz
Copy link

I wanted to make some very specific changes to the WifiClientSecure class, but since SSLContext is defined completely inside the WifiClientSecure.cpp file it makes it significantly harder to deal with it.

It would be a great help to define the SSLContext class in a header so I don't have to reimplement everything if I want to extend the class.
@igrr igrr added this to the 2.5.0 milestone Oct 6, 2017
@igrr igrr self-assigned this Oct 6, 2017
@devyte devyte assigned earlephilhower and unassigned igrr Aug 2, 2018
earlephilhower added a commit to earlephilhower/Arduino that referenced this issue Sep 11, 2018
@earlephilhower
Move SSLContext to its own header
fa1711b 
Simple refactor to make WiFiClientSecureAxTLS use an external header to
define its SSLContext, just as it does for several other classes.

Fixes esp8266#3648
@earlephilhower earlephilhower mentioned this issue Sep 11, 2018
Merged
devyte pushed a commit that referenced this issue Sep 17, 2018
@earlephilhower @devyte
Move SSLContext to its own header (#5121)
991d738 
Simple refactor to make WiFiClientSecureAxTLS use an external header to
define its SSLContext, just as it does for several other classes.

Fixes #3648
d-a-v pushed a commit to d-a-v/Arduino that referenced this issue Sep 18, 2018
@earlephilhower @d-a-v
Move SSLContext to its own header (esp8266#5121)
a058506 
Simple refactor to make WiFiClientSecureAxTLS use an external header to
define its SSLContext, just as it does for several other classes.

Fixes esp8266#3648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@earlephilhower earlephilhower

Labels
component: libraries component: TLS type: enhancement
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
4 participants
@earlephilhower @igrr @schlaegerz @devyte