-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blink Example won't blink #2192
Comments
Please post the sketch you are using, specify which hardware you run it on, and the settings in the IDE which you use. |
I'm using a ESP-12F I did now measure Pin 1 and it's changing state 0V/VCC as it should. On one side of the LED (the one pointing away of pin 1) I can measure VCC
|
@Gorkde, there is no way this sketch could have triggered an LED on ESP12F with 2.2.0. I think example should be updated to note that for ESP12E/F, pin has to be changed to 2. |
Ok, so maybe I had this messed up with my tests on the Wemos but on any of those I had 2.2.0 blink the led I'm pretty sure. But at least I know the reason now, thanks! |
Maybe you shoud just add a Blink_ESP-12 example and a LED_BUILTIN_12. |
Sorry to butt in. Wouldn't it be clearer (though perhaps more work) to define two "generic" variants in the boards list instead of one - one for ESP01-ESPxx where the built-in LED is on GPIO1, and another for ESP12E and others where the LED on GPIO2 (the d1, d1-mini, espino, espresso variants have LED_BUILTIN = 2 already)? There are perhaps other constants which differ too, because of the extra pins on the 12E/F? |
That's what I thought later on also. |
There exists esp12e boards with led connected to gpio1 (early release ones). So i personally think ... no fix there possible, because current releases of them have led connected to gpio2. |
Well, "Blink" is probably the most used sample, and I guess most modules sold today (stand-alone or on a board) have their internal led on GPIO2, so I think it's important that it is made simple for newcomers. |
darn, been looking for this for half an hour now ... read some examples where it said 1 or 3 ... never tried pin 2, was thinking that I did something wrong :) |
sorry to branch off on this topic... how do I change the (Port: "/dev/cu.SLAB_USBtoUART") Mine only shows up as com 1 and com 3. I know it is connect to com 3 because I get 2 squares in the serial monitor window when I connect reset to ground. I cannot get this LED to flash... It doesn't flash when it is transferring. Arduino IDE says it did compile |
Add |
I don't know if it adds anything but in ESP-01 it uses a constant called BUILTIN_LED instead of LED_BUILTIN |
I had to use the PIN 2 too. Then the LED on the board would blink. I got MODEL: ESP8266MOD |
@igrr I consider this straight up user error, but you have set milestone for 2.4.0. Is what you have in mind to change the comments in the blink example? |
@devyte @igrr I've just been adding Maybe putting that behind a comment with an explanation might be the easiest way? Or possibly changing the generic ESP-8266 On the other hand, I agree that it might be clearest to beginners (who are most likely to be using Blink), if there were Blink (ESP-01) and Blink (ESP-12) examples. Plus maybe just mentioning the uncommon generic boards like ESP-07 etc in the comments. |
I think this will likely be addressed by #3722 . |
#define LED_BUILTIN 2 |
Yes, even I had the same problem. |
@suhas101 and @sonugupta4636 Thank you, both! it worked for me when added #define LED_BUILTIN 2 |
@d-a-v is this something that should be addressed by the boards.txt generator? In the generic esp8266 module case, should the BUILTIN_LED be configurable? |
a led menu for generic boards is added in #3722. |
@devyte yes, and If I may, boards.txt in its current form needs fixes, |
This seems to differ by which firmware version you are running. |
@pjparsons : If your ESP doesnt have any built in usb-serial communication hardware, it will require an external one to connect to ur computers USB, such as CP2102 usb-ttl converter or RS232 FTDI adaptor. But as u already have one built-in u can directly connect a usb cable to it which shows as a direct com port. The external serial converters are like those COM ports as well, for boards without USB |
The LED menu is now in latest git, can you please try it and report ? |
#define LED_BUILTIN 1 add this to line 11 to solve the problem |
@d-a-v is there anything pending here? can this be closed? |
Yes, I guess this can be closed. |
Hi everyone; I used ESP8266-12E module-nodeMCU, and upload my codes via Arduino 1.6.8 firmware. When I upload blink example, it works. But when I try to define pin(ex: #define LED_BUILTIN 4) D2 it doesn't give output voltage. I can't understand and fix the problem. I tried to define D1, the result was the same, nothing changed. Has anyone face with same problem? Or do you have any suggestions? Thanks, |
If you select NodeMCU v.1, you don't need to define LED_BUILTIN it's defined inside. And the pin led are GPIO16 -- D0. Read this: https://github.com/esp8266/Arduino/blob/master/doc/boards.rst#nodemcu-10-esp-12e-module |
i need your help can you pls help me
…On Sun, Jan 27, 2019 at 1:23 PM ZaPpInG ***@***.***> wrote:
If you select NodeMCU v.1, you don't need to define LED_BUILTIN it's
defined inside.
And the pin led are GPIO16 -- D0. Read this:
https://github.com/esp8266/Arduino/blob/master/doc/boards.rst#nodemcu-10-esp-12e-module
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2192 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AchuCriElU_Jid94JmhmrQRuXdzQc7Atks5vHhjrgaJpZM4I-WQE>
.
|
Hello, |
@raja-supermario when you visit Mexico ill give you a Free Tour in the city, around 14 hours of twitching configuration in IDE, flashing, making auto reset circuits, and cursing the electronic shop for the lowest prices they offer, etc...my back hurts so much but today you gave it a free day (and a quiet night). With love from Mexico <3 in the near future i giving a chance to the simplest solutions (hope will find them at the begining hehehe) |
It worked without problems with 2.2.0
My LED is ok since it's blinking when uploading.
The Check Config Sketch can upload and is working fine.
Just the LED isn't blinking with ESP8266 Blink example.
The text was updated successfully, but these errors were encountered: