Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hook to run code from user_init #2133

Closed
igrr opened this issue Jun 12, 2016 · 3 comments
Closed

Add a hook to run code from user_init #2133

igrr opened this issue Jun 12, 2016 · 3 comments
Assignees
@d-a-v
Labels
component: core type: enhancement
Milestone
2.5.0

Comments

@igrr
Copy link
Member

igrr commented Jun 12, 2016 •
edited
Loading

As seen in #2111, would be useful to disable WiFi early, and maybe for some other cases as well.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@igrr igrr added this to the 2.4.0 milestone Jun 12, 2016
@igrr igrr mentioned this issue Jun 12, 2016
Closed
@tuxedo0801 tuxedo0801 mentioned this issue Jun 12, 2016
Closed
@devyte
Copy link
Collaborator

devyte commented Oct 17, 2017

@igrr I suggest pushing this one back to 2.5.0 (unless it's trivial to implement?)

@igrr
Copy link
Member Author

igrr commented Oct 17, 2017

Sure. At this point i am not planning on adding more features to 2.4.0, only bug fixes are considered. I guess we can mass-reassign all feature requests from 2.4.0 to 2.5.0.

@igrr igrr modified the milestones: 2.4.0, 2.5.0 Oct 17, 2017
@d-a-v d-a-v self-assigned this Oct 12, 2018
d-a-v added a commit to d-a-v/Arduino that referenced this issue Nov 30, 2018
@d-a-v
weak hook early_setup() esp8266#2111 esp8266#2133 esp8266#2136
671bbac
@d-a-v d-a-v mentioned this issue Nov 30, 2018
Merged
earlephilhower pushed a commit that referenced this issue Dec 4, 2018
@d-a-v @earlephilhower
weak hook preinit() #2111 #2133 #2136 (#5395)
216680b 
* weak hook early_setup() #2111 #2133 #2136

* rename to early_init (more "c" vs early_setup which is more "c++arduino")

* example

* improve earlyWiFi example, slightly change AddrList interface, move WiFi sketches into WiFi examples

* fix CI

* fix local CI runner

* fix local CI runner

* rename early_init() to preinit()

* + static ESP8266WiFiClass::preinit_wifi_off()

* update early disable wifi example

* example update

* IPv6 example update

* Update ESP8266WiFiGeneric.h

camelCase for static method name

* Update ESP8266WiFiGeneric.cpp

camelCase for static method name

* Update EarlyDisableWiFi.ino

Expand comment, fix static method name

* Update core_esp8266_main.cpp

Expanded comment.

* Update core_esp8266_main.cpp

Expanded comment

* Update EarlyDisableWiFi.ino

Expanded comment
@d-a-v
Copy link
Collaborator

d-a-v commented Dec 4, 2018

Closed by #5395

@d-a-v d-a-v closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-a-v d-a-v

Labels
component: core type: enhancement
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
3 participants
@igrr @d-a-v @devyte