Resolve naming conflicts between FS and SD library

esp8266 · Aug 5, 2015 · 5cbaa57 · 5cbaa57
1 parent be2303f
commit 5cbaa57
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 3 deletions.
diff --git a/cores/esp8266/FS.cpp b/cores/esp8266/FS.cpp
@@ -21,6 +21,8 @@
 #include "FS.h"
 #include "FSImpl.h"
 
+using namespace fs;
+
 static bool sflags(const char* mode, OpenMode& om, AccessMode& am);
 
 size_t File::write(uint8_t c) {

diff --git a/cores/esp8266/FS.h b/cores/esp8266/FS.h
@@ -24,6 +24,8 @@
 #include <Arduino.h>
 #include <memory>
 
+namespace fs {
+
 class File;
 class Dir;
 
@@ -106,6 +108,12 @@ class FS
 
 };
 
+} // namespace fs
+
+using fs::FS;
+using fs::File;
+using fs::Dir;
+
 extern FS SPIFFS;
 
 #endif //FS_H
diff --git a/cores/esp8266/FSImpl.h b/cores/esp8266/FSImpl.h
@@ -23,6 +23,8 @@
 #include <stddef.h>
 #include <stdint.h>
 
+namespace fs {
+
 class FileImpl {
 public:
     virtual ~FileImpl() { }
@@ -67,5 +69,6 @@ class FSImpl {
 
 };
 
+} // namespace fs
 
 #endif //FSIMPL_H
diff --git a/cores/esp8266/spiffs_api.cpp b/cores/esp8266/spiffs_api.cpp
@@ -32,6 +32,8 @@ extern "C" {
 #include "spi_flash.h"
 }
 
+using namespace fs;
+
 extern int32_t spiffs_hal_write(uint32_t addr, uint32_t size, uint8_t *src);
 extern int32_t spiffs_hal_erase(uint32_t addr, uint32_t size);
 extern int32_t spiffs_hal_read(uint32_t addr, uint32_t size, uint8_t *dst);

diff --git a/libraries/ESP8266WebServer/src/ESP8266WebServer.cpp b/libraries/ESP8266WebServer/src/ESP8266WebServer.cpp
@@ -24,6 +24,7 @@
 #include <Arduino.h>
 #include "WiFiServer.h"
 #include "WiFiClient.h"
+#include "FS.h"
 #include "ESP8266WebServer.h"
 #include "detail/RequestHandler.h"
 // #define DEBUG
@@ -77,7 +78,7 @@ void ESP8266WebServer::_addRequestHandler(RequestHandler* handler) {
     }
 }
 
-void ESP8266WebServer::serveStatic(const char* uri, FS fs, const char* path) {
+void ESP8266WebServer::serveStatic(const char* uri, FS& fs, const char* path) {
     _addRequestHandler(new StaticRequestHandler(fs, uri));
 }
 

diff --git a/libraries/ESP8266WebServer/src/ESP8266WebServer.h b/libraries/ESP8266WebServer/src/ESP8266WebServer.h
@@ -25,7 +25,6 @@
 #define ESP8266WEBSERVER_H
 
 #include <functional>
-#include <FS.h>
 
 enum HTTPMethod { HTTP_ANY, HTTP_GET, HTTP_POST, HTTP_PUT, HTTP_PATCH, HTTP_DELETE };
 enum HTTPUploadStatus { UPLOAD_FILE_START, UPLOAD_FILE_WRITE, UPLOAD_FILE_END };
@@ -39,6 +38,7 @@ enum HTTPUploadStatus { UPLOAD_FILE_START, UPLOAD_FILE_WRITE, UPLOAD_FILE_END };
 #define CONTENT_LENGTH_NOT_SET ((size_t) -2)
 
 class RequestHandler;
+class FS;
 
 typedef struct {
   HTTPUploadStatus status;
@@ -62,7 +62,7 @@ class ESP8266WebServer
   typedef std::function<void(void)> THandlerFunction;
   void on(const char* uri, THandlerFunction handler);
   void on(const char* uri, HTTPMethod method, THandlerFunction fn);
-  void serveStatic(const char* uri, FS fs, const char* path);
+  void serveStatic(const char* uri, FS& fs, const char* path);
   void onNotFound(THandlerFunction fn);  //called when handler is not assigned
   void onFileUpload(THandlerFunction fn); //handle file uploads