Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extended LLVM mode for LLVM < 17 #437

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

kyrias
Copy link
Contributor

@kyrias kyrias commented Jul 15, 2024

The fix for extended LLVM mode with LLVM 17 accidentally broke it for toolchain versions using LLVM 15 and 16.

@kyrias kyrias force-pushed the fix-extended-llvm-before-17 branch from 04a81d9 to 252ccac Compare July 15, 2024 16:40
The fix for extended LLVM mode with LLVM 17 accidentally broke it for
toolchain versions using LLVM 15 and 16.

Signed-off-by: Johannes Löthberg <[email protected]>
@kyrias kyrias force-pushed the fix-extended-llvm-before-17 branch from 252ccac to 8ba8dcb Compare July 15, 2024 16:41
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix, just did some testing and seems to be working fine.

I'll probably do a patch release tomorrow!

@SergioGasquez SergioGasquez merged commit e108653 into esp-rs:main Jul 17, 2024
17 checks passed
@kyrias kyrias deleted the fix-extended-llvm-before-17 branch July 17, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants