Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link GH workflow & Crates.io badges #568

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

dinomite
Copy link
Contributor

@dinomite dinomite commented Feb 1, 2024

The GH workflow badge was just the raw image, clicking it loaded that image in a new tab.

These were just the badges, which opened the badge image when clicked. Now they link out to the appropriate place.
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Left some minor comments/thoughs

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dinomite
Copy link
Contributor Author

dinomite commented Feb 1, 2024

Updated, but the changelog check is going to fail

@SergioGasquez SergioGasquez added the skip-changelog Skips the changelog CI check label Feb 1, 2024
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SergioGasquez SergioGasquez merged commit 5852e2c into esp-rs:main Feb 1, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips the changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants