Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the newest ESP-HAL's Alarm's method #81

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Fix the newest ESP-HAL's Alarm's method #81

merged 2 commits into from
Nov 17, 2022

Conversation

mozyy
Copy link
Contributor

@mozyy mozyy commented Nov 16, 2022

Fix the newest ESP-HAL's Alarm's method: interrupt_enable

@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 16, 2022

Thanks a lot for your contribution!

Unfortunately, those latest esp-hal changes also cause compile errors for ESP32-S2 and ESP32-S3. I guess you can't test that on hardware but if you could fix those, I can double check on the target hardware.

Seems like just one trait is not in scope for these target

@mozyy
Copy link
Contributor Author

mozyy commented Nov 17, 2022

Thanks for the tip, but I only have ESP32-C3, so only tested ESP32-C3. Now I've tried fixing ESP32-S2 and ESP32-S3 and the compilation is successful, but I don't have the hardware to test them

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the pull request - I successfully tested it on all supported targets

@bjoernQ bjoernQ merged commit ee9ea0d into esp-rs:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants