Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the allocator into an separate crate #31

Merged
merged 1 commit into from
May 16, 2022
Merged

Extract the allocator into an separate crate #31

merged 1 commit into from
May 16, 2022

Conversation

jessebraham
Copy link
Member

New crate's repository can be found here: https://github.com/esp-rs/esp-alloc

Made no real changes to the code which was extracted, only what was necessary to get everything building/running for both chips. I was able to get things working using critical-section==0.2.7 instead of using a git dependency like we had discussed previously.

I did test this on hardware and things seem to be working as expected.

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One thing that changed is the fact that there will be always a global allocator now - which isn't bad since the Wi-Fi driver uses heap memory anyways

@bjoernQ bjoernQ merged commit 974f9ee into esp-rs:main May 16, 2022
@jessebraham
Copy link
Member Author

That's a great point, we can always change this though if needed!

@jessebraham jessebraham deleted the feature/esp-alloc branch May 25, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants