Correct bit width and offset for USB0:HCCHAR:EC field

esp-rs · Jan 6, 2025 · b7ea98f · b7ea98f
1 parent ffbee35
commit b7ea98f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/common_patches/usb0.yaml b/common_patches/usb0.yaml
@@ -269,3 +269,9 @@ _add:
         bitWidth: 32
         writeConstraint: [0, 0xffffffff]
         access: read-write
+
+"HCCHAR?":
+  _modify:
+    EC:
+      bitOffset: 20
+      bitWidth: 2
diff --git a/esp32s2/src/usb0/hc/char.rs b/esp32s2/src/usb0/hc/char.rs
@@ -23,9 +23,9 @@ pub type EPTYPE_R = crate::FieldReader;
 #[doc = "Field `EPTYPE` writer - "]
 pub type EPTYPE_W<'a, REG> = crate::FieldWriter<'a, REG, 2>;
 #[doc = "Field `EC` reader - "]
-pub type EC_R = crate::BitReader;
+pub type EC_R = crate::FieldReader;
 #[doc = "Field `EC` writer - "]
-pub type EC_W<'a, REG> = crate::BitWriter<'a, REG>;
+pub type EC_W<'a, REG> = crate::FieldWriter<'a, REG, 2>;
 #[doc = "Field `DEVADDR` reader - "]
 pub type DEVADDR_R = crate::FieldReader;
 #[doc = "Field `DEVADDR` writer - "]
@@ -68,10 +68,10 @@ impl R {
     pub fn eptype(&self) -> EPTYPE_R {
         EPTYPE_R::new(((self.bits >> 18) & 3) as u8)
     }
-    #[doc = "Bit 21"]
+    #[doc = "Bits 20:21"]
     #[inline(always)]
     pub fn ec(&self) -> EC_R {
-        EC_R::new(((self.bits >> 21) & 1) != 0)
+        EC_R::new(((self.bits >> 20) & 3) as u8)
     }
     #[doc = "Bits 22:28"]
     #[inline(always)]
@@ -137,10 +137,10 @@ impl W {
     pub fn eptype(&mut self) -> EPTYPE_W<CHAR_SPEC> {
         EPTYPE_W::new(self, 18)
     }
-    #[doc = "Bit 21"]
+    #[doc = "Bits 20:21"]
     #[inline(always)]
     pub fn ec(&mut self) -> EC_W<CHAR_SPEC> {
-        EC_W::new(self, 21)
+        EC_W::new(self, 20)
     }
     #[doc = "Bits 22:28"]
     #[inline(always)]

diff --git a/esp32s3/src/usb0/hc/char.rs b/esp32s3/src/usb0/hc/char.rs
@@ -23,9 +23,9 @@ pub type EPTYPE_R = crate::FieldReader;
 #[doc = "Field `EPTYPE` writer - "]
 pub type EPTYPE_W<'a, REG> = crate::FieldWriter<'a, REG, 2>;
 #[doc = "Field `EC` reader - "]
-pub type EC_R = crate::BitReader;
+pub type EC_R = crate::FieldReader;
 #[doc = "Field `EC` writer - "]
-pub type EC_W<'a, REG> = crate::BitWriter<'a, REG>;
+pub type EC_W<'a, REG> = crate::FieldWriter<'a, REG, 2>;
 #[doc = "Field `DEVADDR` reader - "]
 pub type DEVADDR_R = crate::FieldReader;
 #[doc = "Field `DEVADDR` writer - "]
@@ -68,10 +68,10 @@ impl R {
     pub fn eptype(&self) -> EPTYPE_R {
         EPTYPE_R::new(((self.bits >> 18) & 3) as u8)
     }
-    #[doc = "Bit 21"]
+    #[doc = "Bits 20:21"]
     #[inline(always)]
     pub fn ec(&self) -> EC_R {
-        EC_R::new(((self.bits >> 21) & 1) != 0)
+        EC_R::new(((self.bits >> 20) & 3) as u8)
     }
     #[doc = "Bits 22:28"]
     #[inline(always)]
@@ -137,10 +137,10 @@ impl W {
     pub fn eptype(&mut self) -> EPTYPE_W<CHAR_SPEC> {
         EPTYPE_W::new(self, 18)
     }
-    #[doc = "Bit 21"]
+    #[doc = "Bits 20:21"]
     #[inline(always)]
     pub fn ec(&mut self) -> EC_W<CHAR_SPEC> {
-        EC_W::new(self, 21)
+        EC_W::new(self, 20)
     }
     #[doc = "Bits 22:28"]
     #[inline(always)]