-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#41, #36 #42
#41, #36 #42
Conversation
948bd1f
to
37ebfa4
Compare
b523a9b
to
04cf263
Compare
Okay, I think, at least the for the I've refactored @ivmarkov 's code pretty heavily and also incorporated the changes I've made in The biggest change is that I've also added a big Basically:
There are also some errors and warnings for edge cases. On windows, activated esp-idf detection currently doesn't work because the |
7adedbb
to
ef71c2e
Compare
a7908b4
to
4467def
Compare
As the subject says, this is fixing #41 and #36.
The changes should be relatively straightforward actually, with the non-trivial changes actually being part of the
espidf
module inembuild
.See this PR for the
embuild
-related changes:esp-rs/embuild#29