-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP-IDF 5.2 #416
ESP-IDF 5.2 #416
Conversation
CI fails though? |
@@ -470,6 +470,11 @@ where | |||
), | |||
)))] | |||
custom_spi_driver: eth_spi_custom_driver_config_t::default(), | |||
#[cfg(all( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition is not well done (and ditto for all conditions below), in that - once ESP IDF 6.X is out - this will stop working. You probably want to express instead something equivalent to cfg(esp_idf_version >= 5.2)
.
It seems to me this is because esp-idf-hal needs to be updated as well. |
No. The problem is in |
I can't test the RISC-V targets: error[E0463]: can't find crate for `core`
|
= note: the `riscv32imc-esp-espidf` target may not be installed
= help: consider downloading the target with `rustup target add riscv32imc-esp-espidf` |
Did you try what the compiler suggested? |
Of course...
|
I think you are NOT really compiling with Also can you do: $ rustc --print target-list | grep espidf It should print something like:
|
This is now addressed in |
ESP-IDF 5.2 adds a new field to the SPI ethernet configurations:
So far I have simply added the field and it passes
cargo check
, but there might be some further changes required?