Fix enums from esp-idf-sys.
#54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
improve-codegen
branch
20 times, most recently
from
44629e2
to
ef7cfc4
Compare
reitermarkus
force-pushed
the
improve-codegen
branch
from
ef7cfc4
to
d8de2e3
Compare
reitermarkus
force-pushed
the
improve-codegen
branch
4 times, most recently
from
aa68b81
to
c0f7765
Compare
reitermarkus
force-pushed
the
improve-codegen
branch
from
c0f7765
to
b375a57
Compare
reitermarkus
force-pushed
the
improve-codegen
branch
from
b375a57
to
fdeb75f
Compare
MabezDev
reviewed
Mar 26, 2022
| @@ -13,14 +13,17 @@ readme = "README.md" | |||
| documentation = "https://esp-rs.github.io/esp-idf-hal/" | |||
|
|
|||
| [features] | |||
| default = ["std", "alloc", "esp-idf-sys", "embedded-svc"] | |||
| default = ["std", "alloc", "esp-idf-sys", "embedded-svc", "pio"] | |||
There was a problem hiding this comment.
We recently switched to native as the default for esp-idf-sys. The pio feature should be opt-in, not the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on esp-rs/esp-idf-sys#76.